Draft
Remove TraversePropertiesDsl from top-level toDataFrame {} operation#2004
Conversation
Copilot
AI
changed the title
[WIP] Remove
Remove TraversePropertiesDsl from top-level toDataFrame {} operation
Jul 28, 2026
TraversePropertiesDsl from top-level toDataFrame {} operation
Collaborator
|
Seems like a good base, I'll continue from this |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR simplifies the Iterable<T>.toDataFrame {} DSL by removing TraversePropertiesDsl from the top-level receiver, so traversal-related configuration (exclude/preserve) is scoped to properties {} blocks (matching the compiler plugin’s supported notation and avoiding previously confusing/broken behavior).
Changes:
- Remove
TraversePropertiesDslinheritance/delegation fromCreateDataFrameDsl/CreateDataFrameDslImpl. - Add WARNING-level deprecated shims (
exclude/preserveandpreserve<T>()) onCreateDataFrameDslto ease source migration. - Update tests, generated sources, and
apiDumpto reflect the new API surface.
Reviewed changes
Copilot reviewed 5 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| core/src/test/kotlin/org/jetbrains/kotlinx/dataframe/api/toDataFrame.kt | Updates the test to use preserve<T>() inside a properties {} block. |
| core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/util/deprecationMessages.kt | Adds a dedicated deprecation message for the removed top-level traversal DSL usage. |
| core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/impl/api/toDataFrame.kt | Removes TraversePropertiesDsl delegation from CreateDataFrameDslImpl. |
| core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/api/toDataFrame.kt | Removes TraversePropertiesDsl from CreateDataFrameDsl and adds deprecated migration shims. |
| core/generated-sources/src/main/kotlin/org/jetbrains/kotlinx/dataframe/util/deprecationMessages.kt | Regenerates the deprecation message constant. |
| core/generated-sources/src/main/kotlin/org/jetbrains/kotlinx/dataframe/impl/api/toDataFrame.kt | Regenerates the CreateDataFrameDslImpl signature without delegation. |
| core/generated-sources/src/main/kotlin/org/jetbrains/kotlinx/dataframe/api/toDataFrame.kt | Regenerates the public DSL API with deprecated shims and updated inheritance. |
| core/api/core.api | Updates the binary API dump to reflect removed supertype and added shim methods. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Remove TraversePropertiesDsl as supertype of CreateDataFrameDsl<T>
- Remove TraversePropertiesDsl delegation from CreateDataFrameDslImpl
- Add deprecated exclude/preserve methods to CreateDataFrameDsl with deprecation warning pointing to properties {} block
- Add deprecated preserve<T>() extension for CreateDataFrameDsl
- Update preserve T test to use properties {} block instead of top-level preserve()
- Update generated sources and binary API file
- Add TRAVERSE_PROPERTIES_DSL deprecation message constant
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Jolanrensen
force-pushed
the
copilot/remove-traversepropertiesdsl
branch
from
July 29, 2026 13:42
13f7721 to
72f2d66
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Top-level
preserve()/exclude()calls insidetoDataFrame {}had broken semantics: they were supposed to apply to allproperties {}blocks but did not work reliably, and calling them without anyproperties {}block produced an empty DataFrame. The compiler plugin also never supported this notation.Changes
CreateDataFrameDsl<T>no longer extendsTraversePropertiesDsl—exclude()andpreserve()are no longer directly available at the top level oftoDataFrame {}CreateDataFrameDslImpl— removedTraversePropertiesDsl by configurationdelegationexclude(),preserve(), andpreserve<T>()are kept onCreateDataFrameDslwithDeprecationLevel.WARNING(→ ERROR in 1.1), forwarding to aproperties {}block to ease migrationapiDump; methods remain in bytecode for binary compatibilityMigration
TraversePropertiesDslfrom top-leveltoDataFrame {}operation #1857